Comments on: Code Reviews: A Framework for Startups http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/ Summary of your social news feeds! Sun, 05 May 2013 03:40:40 +0000 hourly 1 http://wordpress.com/ By: Mircea Paşoi http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-61 Mon, 03 Oct 2011 08:02:00 +0000 http://blog.summify.com/?p=7620610348#comment-61 First of all, the stuff Facebook open-sources isn’t too good/stable. Second, doing this before commit would only be a small benefit for such a small company, we can communicate fast enough that it’s not a real problem.

]]> By: Tibi http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-60 Sun, 02 Oct 2011 10:43:06 +0000 http://blog.summify.com/?p=7620610348#comment-60 Why don’t you do this before commit? User should not be allowed to commit code without successfully passing test-cases. Facebook released the thing they’re using to the public https://github.com/facebook/arcanist. It’s pretty neat.

]]> By: Mircea Paşoi http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-57 Sun, 25 Sep 2011 00:14:50 +0000 http://blog.summify.com/?p=7620610348#comment-57 Whenever someone pushes code to the “master” branch Jenkins automatically runs all the unit tests on a dedicated machine. If anything fails, an email is sent that the “build is unstable”.

]]> By: Ghise Alexandru http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-56 Sat, 24 Sep 2011 10:46:23 +0000 http://blog.summify.com/?p=7620610348#comment-56 Can you please expand on how you use continuous integration / jenkins?

]]> By: Mircea Paşoi http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-54 Fri, 23 Sep 2011 22:23:27 +0000 http://blog.summify.com/?p=7620610348#comment-54 You don’t always want to download the diff and apply it, and screenshots are super easy to review in ReviewBoard.

]]> By: Mircea Paşoi http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-53 Fri, 23 Sep 2011 22:22:06 +0000 http://blog.summify.com/?p=7620610348#comment-53 Not necessarily. Mistakes will happen, but in a creative environment avoiding mistakes is often more expensive than making them and fixing them fast.

]]> By: Cristian Andreica http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-52 Fri, 23 Sep 2011 20:02:15 +0000 http://blog.summify.com/?p=7620610348#comment-52 Great article, guys! Code-review is probably that one thing that totally shifted my perspective on how code should be developed/deployed.

One question: why do screenshots are that important when reviewing code/posting a review?

Almost all the time, I download the diff, patch it locally and test the change. Any UI change is visible.

]]> By: A.A.A. http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-51 Fri, 23 Sep 2011 07:53:28 +0000 http://blog.summify.com/?p=7620610348#comment-51 Should the reviews always be more skilled and experienced than the developer ? What if the reviewr is wrong in some task (don’t know some patterns or refactoring paradigms, or don’t accept some knowledge from good book)

]]> By: Mircea Paşoi http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-50 Fri, 23 Sep 2011 01:23:59 +0000 http://blog.summify.com/?p=7620610348#comment-50 Probably ~1h on average, although some stuff can take up to 24h to get shipped (b/c of multiple iterations on the reviews).
Verbal communication definitely helps and if something is really really urgent you can do the review after pushing and deploying the code (post-commit code review).

]]> By: Robin Campbell http://blog.summify.com/2011/09/21/code-reviews-a-framework-for-startups/#comment-48 Thu, 22 Sep 2011 17:25:28 +0000 http://blog.summify.com/?p=7620610348#comment-48 Thanks for sharing James! We’re glad you found it helpful. If you’d like to let us know how Summify could be better suited to you please drop us a line at team[at]summify.com.

]]>